Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: comment on GitHub step summary #986

Merged
merged 2 commits into from
Aug 23, 2023
Merged

feat: comment on GitHub step summary #986

merged 2 commits into from
Aug 23, 2023

Conversation

koozz
Copy link
Contributor

@koozz koozz commented Jul 14, 2023

Using the GitHub step summary feature, the Pulumi output can be stored on the GitHub step. This defeats the need to dive into the individual steps and find the Pulumi output.

The input parameter comment-on-summary has the non-breaking default false. If true, then the action will add the results of the Pulumi action to the GitHub step summary.

Have tested it by referencing fork:

  - uses: koozz/pulumi-actions@e399df46ff12c78394bba8dbb593c13bacf9b844
    with:
      comment-on-summary: true
      # ...

Showing the output in the Job summary:

image

Fixes: #761

@simenandre
Copy link
Contributor

@koozz Would you mind removing the dist files update so we can run the workflow tests on this change? :)

It's a bit weird how this goes, but we optimized it so that changes that did nothing to our dist files were skipped. Which I at least think is why they are not triggered 😅

@koozz
Copy link
Contributor Author

koozz commented Jul 14, 2023

@koozz Would you mind removing the dist files update so we can run the workflow tests on this change? :)

It's a bit weird how this goes, but we optimized it so that changes that did nothing to our dist files were skipped. Which I at least think is why they are not triggered 😅

Sure one sec.
I removed it, but it got added again by the pulumi/actions workflows on my fork. Shall I disable these?

Using the GitHub step summary feature, the Pulumi output can be stored on the
GitHub step. This defeats the need to dive into the individual steps and find
the Pulumi output.

The input parameter comment-on-summary has the non-breaking default false. If
true, then the action will add the results of the Pulumi action to the GitHub
step summary.

Signed-off-by: Jan van den Berg <koozz@linux.com>
@koozz koozz force-pushed the master branch 2 times, most recently from b8b90be to 5c7a971 Compare July 14, 2023 11:27
@koozz
Copy link
Contributor Author

koozz commented Jul 14, 2023

@simenandre I just disabled the workflows on my fork and dropped the automated commit from the PR.

@simenandre simenandre requested a review from justinvp July 14, 2023 11:50
@koozz
Copy link
Contributor Author

koozz commented Jul 19, 2023

Hi @justinvp, please tag me if I need to change something else.

@ma-ts
Copy link

ma-ts commented Jul 25, 2023

Wow! Amazing feature. Would love to see this merged.

@koozz
Copy link
Contributor Author

koozz commented Aug 8, 2023

Hi @simenandre,

you added @justinvp but maybe there's someone else who can review and merge it?

Kind regards and let me know if an update is required,
Jan

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your patience!

@justinvp justinvp merged commit 13b88a5 into pulumi:master Aug 23, 2023
@gunzy83 gunzy83 mentioned this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using GITHUB_STEP_SUMMARY
4 participants