-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: comment on GitHub step summary #986
Conversation
@koozz Would you mind removing the dist files update so we can run the workflow tests on this change? :) It's a bit weird how this goes, but we optimized it so that changes that did nothing to our dist files were skipped. Which I at least think is why they are not triggered 😅 |
Sure one sec. |
Using the GitHub step summary feature, the Pulumi output can be stored on the GitHub step. This defeats the need to dive into the individual steps and find the Pulumi output. The input parameter comment-on-summary has the non-breaking default false. If true, then the action will add the results of the Pulumi action to the GitHub step summary. Signed-off-by: Jan van den Berg <koozz@linux.com>
b8b90be
to
5c7a971
Compare
@simenandre I just disabled the workflows on my fork and dropped the automated commit from the PR. |
Hi @justinvp, please tag me if I need to change something else. |
Wow! Amazing feature. Would love to see this merged. |
Hi @simenandre, you added @justinvp but maybe there's someone else who can review and merge it? Kind regards and let me know if an update is required, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your patience!
Using the GitHub step summary feature, the Pulumi output can be stored on the GitHub step. This defeats the need to dive into the individual steps and find the Pulumi output.
The input parameter
comment-on-summary
has the non-breaking defaultfalse
. Iftrue
, then the action will add the results of the Pulumi action to the GitHub step summary.Have tested it by referencing fork:
Showing the output in the Job summary:
Fixes: #761